anonymisedRtdProvider: Anonymised Marketing Tag external script QSP updated#14623
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Anonymised RTD Provider’s default Marketing Tag loader URL to include the current page’s domain as a query string parameter, so the external script receives publisher domain context when loaded by Prebid RTD.
Changes:
- Append
d=<window.location.hostname>to the default Marketing Tag URL whenparams.tagUrlis not provided. - Update the unit test expectation for the loaded script URL to include the new
dparameter.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
modules/anonymisedRtdProvider.js |
Adds &d=${window.location.hostname} to the default Marketing Tag loader URL. |
test/spec/modules/anonymisedRtdProvider_spec.js |
Updates expected loadExternalScript URL to match the new default format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d5e530a9a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Pull Request Test Coverage Report for Build 23347685384Details
💛 - Coveralls |
Type of change
Description of change
Anonymised RTD Provider: append current domain to Marketing Tag URL
Appends the publisher's domain as a d query parameter to the Anonymised Marketing Tag script URL when it is loaded by the RTD provider.
Before:
https://static.anonymised.io/light/loader.js?ref=prebidAfter:
https://static.anonymised.io/light/loader.js?ref=prebid&d=example.comThe domain is read from
window.location.hostname, which returns the ASCII/punycode hostname and requires no additional encoding. This change only applies when no customtagUrlis provided — publisher-supplied URLs are passed through unchanged. The unit test for script loading has been updated to reflect the new URL format.Other information